Let $f : \mathbb{R}^3 \to \mathbb{R}, f(x, y, z) = x + y + z$ with constraints $$x + z = 1 \text{ and } x^2 + y^2 = 4 $$
Now it says "The constraint set is the intersection of a cylinder [I understand this, with radius $4$ and $z$ arbitrary] and a plane [Obv $y$ is arbitrary here but how can I interpret $1$ here?]. Since the plane does not intersect the cylinder perpendicularly [because $z \neq 0$?], the intersection is an ellipse and, therefore, compact." Why is is important that the intersection is an ellipse? Wouldn't this be true if the interection was a circle? For $x=0$ the intersection would be an infinite line, wouldn't this be 'worse'?
The $x+z=1$ is a plane, because you can think of it as a line on the $xz$ plane $z = 1 - x$ which is then propagated along the $y$ axis.
"The intersection is a circle if $x=0$" is simply an irrelevant claim. $x$ is not 0, it appears in the equation of the surface you're intersecting. The plane is a constant object, with a unique formula. There are no "parameters" here of which you're free to chose the value. If $x=0$ then $z=1$, and $y$ is arbitrary.
The fact the the intersection is an ellipse is indeed irrelevant for claiming it's compact, but may be relevant in the following text which you omitted.
The fact that the intersection is compact is non-trivial a-priori, since you're intersecting two non-compact surfaces. The reason it is compact is because $z$ is bounded in the plane eq. as long as $|x|<2$ (which is a constraint of the cylinder equation), so you don't really need the actual geometric shape for that.