Is my proof that $(x,y)\subset \mathbb Q[x,y]$ is not a principal ideal correct?
Suppose $(x,y)=(f(x,y))$. Since $x,y\in (x,y)$, the degree of $f$ in $x$ and $y$ (separately) cannot exceed 1. So $f(x,y)=ax+by+c$. Since $x\in (x,y)$, there must exist $g(x,y)$ such that $f(x,y)g(x,y)=x$. The only event in which this happens is when $f(x,y)=ax,\ g(x,y)=1/a$. So $b=c=0$. Since $y\in (x,y)$, $a=c=0$. Thus $f(x,y)=0$. But $(x,y)$ is not the zero ideal, a contradiction.
I second Alex J Best's comment about a little proof fix, but also I think it's worth noting that this holds in $R[x,y]$ for $R$ any commutative ring with identity. So $\mathbb{Q}$ is not special in this regard. Your proof will continue to work for any integral domain. But if $R$ has zero divisors, you cannot immediately say that $f$ has degree $1$, and the proof is a little more complicated.
You might like to try to prove the following for a general ring $R$
This immediately implies that $(x,y)$ is not principal. I include a proof sketch in the spoiler below if you are interested. Like your proof, it mostly involves comparing coefficients.