Suppose we have matrix of the form
$$ A= \begin{bmatrix} a & -1 \\ 0 & a \\ \end{bmatrix} $$
and we would like to analyze its diagonalizability.
By taking the characteristic equation we quickly find $a^2 = 0$. In this case, can we say that this matrix has eigenvalue of 0 with infinite multiplicity?
You're computing the determinant of $A$, which is not the characteristic polynomial. The characteristic polynomial is rather $$ \det(A-XI)=\det\begin{bmatrix}a-X&-1\\0&a-X\end{bmatrix}=(a-X)^2 $$ which has one root (equal to $a$) with multiplicity $2$.
The matrix is not diagonalizable, because $$ A-aI=\begin{bmatrix}0&-1\\0&0\end{bmatrix} $$ has rank $1$.