Consider $y = x^2 + ax - a$ for positive integral values of $a,x$.
I am ultimately looking for sufficient conditions for $y$ to be a perfect square, but necessary conditions or hints will also be helpful.
I have already tried a few techniques in modular arithmetic, and considered the values of $a,x$ for which $y$ lies between 2 consecutive squares. The latter only provides a bound for $x$ depending on the value of $a$ chosen:
$4x \leq (a + 1)^2$ for odd $a$ and $8x \leq a^2 + 4$ for even $a$.
HINT.-Maybe do you want to try with the following. $$x^2+ax-a=y^2\iff \left(x+\frac a2\right)^2+1=y^2+\left(\frac a2+1\right)^2$$
Now you have the general solution of the equation $$X^2+Y^2=Z^2+W^2$$ is given by $$\begin{cases}2X=tM+sN\\2Y=tN-sM\\2Z=tM-sN\\2W=tN+sM\end{cases}$$ where $t,s,M,N$ are arbitrary integers.