Hi everyone I'd like to know if the following is correct. I really appreciate any suggestion. (Honestly the only one that matters me is the second property the others are easy, I think) Thanks.
Definition: Let $X\subset \mathbb{R}$ and let $x'\in \mathbb{R}$, we say that $x'$ is an adherent point of $X$ iff $\,\forall\varepsilon>0\,\exists x\in X \text{ s.t.} \; d(x',x)\le \varepsilon$. We say that $\overline{X}$ is the closure of $X$ iff contain all the adherent points of $X$.
Lemma (Elementary properties of Closures): Let $X$ and $Y$ be arbitrary subset of $\mathbb{R}$. Then $X\subset \overline{X}, \; \overline{X\cup Y}=\overline{X}\cup\overline{Y},\; \overline{X\cap Y}\subset\overline{X}\cap\overline{Y}$. If $X\subset Y$ then $\overline{X}\subset \overline{Y}$.
Proof: Clearly if $x\in X$, $x$ is $\varepsilon$-adherent to $x$ (indeed is $0$-close to itself) for every $\varepsilon$, hence $x\in \overline X$.
Let $z'$ be an adherent point of $X\cup Y$, then there exists some $z\in X\cup Y$ such that $d(z',z)$ for a given $\varepsilon>0$. Suppose $z\in X$, hence $z'$ is an adherent point of $X$, i.e., $z'\in \overline{X}\subset \overline{X}\cup \overline{Y}$. Similarly when $z\in Y$, $z'\in \overline{Y}\subset \overline{X}\cup \overline{Y}$. Thus $ \overline{X\cup Y}\subset\overline{X}\cup \overline{Y}$. We know that $X\cup Y \subset\overline{X\cup Y}\subset\overline{X}\cup \overline{Y}$. Then $\overline{\overline{X\cup Y}}=\overline{X}\cup \overline{Y}$. Since $\overline{\overline{X\cup Y}} = \overline{X\cup Y}$ we're done.
Let $z'\in \overline{X\cap Y}$, i.e., $z'$ is an adherent point of $X\cap Y$. So, there is some $z\in X\cap Y \subset X$ such that $d(z',z)\le \varepsilon$ for any given $\varepsilon>0$. It follows that $z'$ is an adherent point of $X$, i.e., $z'\in \overline{X}$. Similarly since $z\in X\cap Y \subset Y$ we have $z'\in \overline{Y}$. Hence $z'\in \overline{X}\cap\overline{Y}$.
Let $x'\in \overline{X}$ we'd like to show that $x'\in \overline{Y}$. Let $\varepsilon>0$ be arbitrary then $\exists x\in X\subset Y$ such that $d(x',x)\le \varepsilon$, so $x'$ is an adherent point of $Y$, i.e., $x'\in \overline{Y}$ as desired. $\Box$
Claim 1: If $X\subset Y \subset \overline{X}$. Then $\overline{Y}=\overline{X}$.
Proof claim: Let $y'$ be an adherent point of $Y$, i.e., $y'\in \overline{Y}$ and let $\varepsilon>0$ be given. Thus, $\exists y \in Y\subset \overline{X}$ s.t. $d(y,y')\le \varepsilon$. So, $y$ is an adherent point of $X$. Thus $\exists x\in X$ s.t. $d(x,y)\le \varepsilon$ and therefore we must have $d(x,y')\le 2\varepsilon$ which shows that $y'$ is an adherent point of $X$, i.e., $\overline{Y}\subset \overline{X}$. Conversely if $x'$ is an adherent point of $X$. Then $\exists x\in X\subset Y$ s.t. $d(x,x')\le \varepsilon$, and so is adherent to $Y$. $\Box$
Claim 2: $\overline{\overline{X}} = \overline{X}$
Proof: It will suffice to show that if $x''\in \overline{\overline{X}}$, then $x''$ is an adherent point of $X$. Let $\varepsilon >0$ be arbitrary and let $x''$ be an adherent point of $\overline{X}$. Then there is some $x' \in \overline{X}$ such that $d(x'',x')\le \varepsilon$. Since $x' \in \overline{X}$ by definition is an adherent point of $X$, so there is some $x\in X$ for which $d(x,x')\le \varepsilon$. Thus $d(x,x'')\le d(x,x')+d(x',x'')\le 2\varepsilon$ it follows that $x''$ is an adherent point of $X$ as desired. $\Box$
The proof of claim 2 looks good to me, but there's a faster way: Use claim 1, and set $Y=\overline{X}$. The result follows directly.
You could go the other way too, and treat claim 1 and a corollary to claim 2. Your lemma gives you $$ \overline{X} \subseteq \overline{Y} \subseteq \overline{\overline{X}} $$ but since claim 2 gives you $$ \overline{X} = \overline{\overline{X}}, $$ you're done!
One little thing though: you don't need "iff" in definitions: an "if" will suffice.
If you state as a definition the following
no one is going to ask "what if 2 isn't a factor, can we still call it even?" The "only if" is implicit in the fact that we are stating a definition. This does not apply to propositions/theorems though!