Disclaimer: I am not a student trying to get free internet homework help. I am an adult who is learning Calculus. I am deeply grateful to the members of this community for their time.
I am not sure why you need to use B vs. Bx+C. I tried both, and got 2 different answers. In the past, the only explanation I got to why you need to use Bx+C is that just using B would not give an answer. Well, this time both ways yielded an answer. Why is one incorrect??


A simple sanity check shows that your second solution is incorrect: $$\frac{1}{x^2+x+1} - \frac{1}{x-1} = \frac{x-1 - x^2 -x - 1}{(x-1)(x^2+x+1)} = \frac{-x^2-2}{x^3-1}\neq \frac{x^2-2x-2}{x^3-1}$$
It is easiest to explain why your second approach does not work using the language of linear algebra. Let $P_2(\Bbb R)$ be the vector space of all polynomials of degree $\leq 2$. In addition, let: $$f(x) = x^2+x+1$$ $$g(x) = x - 1$$ $$h(x) = x^2 - x$$ In your second approach, you are attempting to find a linear combination of $f(x)$ and $g(x)$ that yields $x^2-2x-2$. But this is impossible because $x^2-2x-2$ is not in the span of $f(x)$ and $g(x)$. Thus, there are no constants $A,B$ such that $Af + Bg = x^2 - 2x - 2$. Using $Bx+C$ instead of $B$ works because it will give you three polynomials that span all of $P_2(\Bbb R)$ (from your first approach, you can see that these polynomials are $f(x)$, $g(x)$, and $h(x)$). Hence, you are guaranteed to be able to find constants $A,B,C$ such that $Af + Bg + Ch = x^2-2x-2$.
Note also that when you solved for $A,B$ in your second approach, you were essentially constructing a parabola that matches $x^2-2x-2$ on exactly two points. There are infinitely many such parabolas. A parabola is uniquely defined by three points, so if you want to make sure that whatever you are solving for ends up being equal to $x^2-2x-2$, you must confirm that there are three points that both of them pass through. Obviously, you cannot force that to happen using your second approach, since $A(x^2+x+1) + B(x-1)$ can be completely defined using only two points. So that approach will fail most of the time.