For any two sets $A$ and $B$ in a space $X$, $$\text{cl}(A \cup B)=\text{cl}(A) \cup \text{cl}(B)$$ where $\text{cl}(Y)$ denote the closure of $Y$
This question and its answer are already available in this site. Why I am posting here is "to check my proof". Here's My try:
$$x \in \text{cl}(A \cup B) \Leftrightarrow \exists \;r>0 \;\text{such that}\;B_r(x) \cap (A \cup B) \neq \emptyset$$
$$\Leftrightarrow (B_r(x) \cap A)\cup (B_r(x) \cap B) \neq \emptyset$$
$$\Leftrightarrow (B_r(x) \cap A) \neq \emptyset \;\text{or}\;(B_r(x) \cap B) \neq \emptyset$$
$$\Leftrightarrow x \in \text{cl}(A)\; \text{or}\; x \in \text{cl}(B)$$
$$\Leftrightarrow x \in \text{cl}(A) \cup \text{cl}(B)$$
Is this right?
I take issue with your first equivalence. Take the open ball of radius $1$ and center $0$. Then for a point $p$, a ball $B_r(p)$ intersects $B_1(0)$ if you take $r = \mathrm{dist(p,0)}$. Is the closure of $B_1(0)$ the full space $\mathbb R^n$ ?
The equivalence you should have is:
$$ x\in \mathrm{cl}({x}) \Leftrightarrow \forall r > 0: B_r(x) \cap(A \cup B) \ne \varnothing $$
But you have an issue in the sense that for a given $x$, $B_r(x)$ will intersect either with $A$ or $B$ and so far that depends on $r$. But you must have either $A$ or $B$ that intersects with $B_r(x)$ for all $r > 0$, not some of them depending on $r$, so you have additional steps to do.
Note that if there is a radius $r_1$ such that $B_{r_1}(x)$ intersects $A$ but not $B$, for any $0 < r_2 < r_1$, $B_{r_2}(x)$ cannot intersect $B$, else you contradict the conditions on $r_1$. Moreover, for $r_3 > r_1$, $B_{r_3}(x)$ must intersect $A$ since $B_{r_1}(x) \subset B_{r_3}(x)$. Thus, you can see that for a given $x$, if there is an $r_1$ such that $B_{r_1}(x)$ does not intersect $B$, then for all $r>0$, $B_{r}(x)$ intersects $A$.