Prop: If $T : V \rightarrow V$ and if $v_1,...,v_n$ is a basis such that $T$ is diagonal, then the $v_i$ are eigenvectors.
Pf: The eigenvalues of a diagonal matrix are its diagonal entries.
Let $[T] = \begin{pmatrix} a_1 & 0 & \dots & 0 \\ 0 & a_2 & \dots & 0 \\ \vdots & \vdots & \ddots & \vdots \\ 0 & 0 & \dots &a_n \end{pmatrix}$, where the columns of $[T]$ are basis vectors.
$[T][v_i] = \begin{pmatrix} a_1 & 0 & \dots & 0 \\ 0 & a_2 & \dots & 0 \\ \vdots & \vdots & \ddots & \vdots \\ 0 & 0 & \dots &a_n \end{pmatrix}\begin{pmatrix} a_1 \\ 0 \\ \vdots \\ 0\end{pmatrix}=\begin{pmatrix} a^2_1 \\ 0 \\ \vdots \\ 0\end{pmatrix}=\lambda\begin{pmatrix} a_1 \\ 0 \\ \vdots \\ 0 \end{pmatrix} =\lambda [v_i] \square$
Does my proof look right?
I can't understand your proof.
Anyhow, we want to show that $Tv_i= \lambda_i v_i$ for some $\lambda_i$ a scalar, for every $i$.
Now $Tv_i= \begin{pmatrix} a_1 & 0 & \dots & 0 \\ 0 & a_2 & \dots & 0 \\ \vdots & \vdots & \ddots & \vdots \\ 0 & 0 & \dots &a_n \end{pmatrix} \begin{pmatrix} 0 \\ \vdots \\ 1 \\ \vdots \\ 0 \end{pmatrix}=\begin{pmatrix} 0 \\ \vdots \\ a_i \\ \vdots \\ 0 \end{pmatrix}=a_i\begin{pmatrix} 0 \\ \vdots \\ 1 \\ \vdots \\ 0 \end{pmatrix}=a_iv_i$
So every $v_i$ is an eigenvector with eigenvalue $a_i$