Ross defines the Archimedean Property as follows:
If $a>0$ and $b>0$ , then for some integer $n$, we have $na>b$.
Here is problem 4.10:
Prove that if $a>0$ , then there exists $n$ (element of natural numbers) such that $\frac{1}{n}< a < n$ .
Solution: We consider two cases:
Case 1: $a>1$ , then since $a>0 $we can choose a positive integer $n$ such that $a < n$. From $a< n$ we deduce that $\frac{1}{a}>\frac{1}{n}$ and because $a>1$ we have $a>\frac{1}{a}$, hence $a>\frac{1}{n}$. Therefore $\frac{1}{n}< a < n$.
Case 2: $0 < a < 1$. Then since $a>0$ we can choose a positive integer $n$ such that $\frac{1}{n}< a$. From $\frac{1}{n}< a$ we deduce that $n>\frac{1}{a}$ and because $0< a < 1$ we have $\frac{1}{a}>a$ , hence $n >a$ .Therefore $\frac{1}{n}< a < n$.
I have seen a shorter proof online, I am only asking if my solution is correct.
Seems perfectly fine to me. However, you are missing the case $a=1$; of course this is trivial as for $a=1$ then any $n \in \mathbb{N}$ strictly greater than $1$ satisfies $\frac{1}{n} < a < n$, but one should include this in the proof.