So I am trying to simplify $\tanh(\operatorname{arsinh}(x))$ to $\frac{x}{\sqrt{1+x^2}}$
In general,
$$\tanh(x) = \frac{e^x-e^{-x}}{e^x+e^{-x}}$$
and $$\operatorname{arsinh}(x)= \ln(x+\sqrt{x^2-1})$$
therefore
\begin{align}\tanh(\operatorname{arsinh}(x)) & =\frac{e^{\ln(x+\sqrt{x^2-1})}-e^{\ln(\frac{1}{x+\sqrt{x^2-1}})}}{e^{\ln(x+\sqrt{x^2-1})}+e^{\ln(\frac{1}{x+\sqrt{x^2-1}})}}\\ &=\frac{x+\sqrt{x^2-1}-\frac{1}{x+\sqrt{x^2-1}}}{x+\sqrt{x^2-1}+\frac{1}{x+\sqrt{x^2-1}}} \\ &=\frac{(x+\sqrt{x^2-1})^2-1}{(x+\sqrt{x^2-1})^2+1} \\ &=\frac{x^2+2x\sqrt{x^2-1}+x^2-1-1}{x^2+2x\sqrt{x^2-1}+x^2-1+1} \\ &=\frac{x^2+x\sqrt{x^2-1}-1}{x^2+x\sqrt{x^2-1}} \\ &=\frac{x^2+x\sqrt{x^2-1}}{x^2+x\sqrt{x^2-1}}-\frac{1}{x^2+x\sqrt{x^2-1}} \\ &=1-\frac{1}{x(x+\sqrt{x^2-1})} \\ &=1-\frac{x-\sqrt{x^2-1}}{x(x+\sqrt{x^2-1})(x-\sqrt{x^2-1})} \\ &=1-\frac{x-\sqrt{x^2-1}}{x(x^2-x^2+1)} \\ &=1-\frac{x-\sqrt{x^2-1}}{x} \\ &=\frac{\sqrt{x^2-1}}{x} \\ &\ne \frac{x}{\sqrt{1+x^2}} \end{align}
I'm struggling to get my answer into the required form.
Your route is fine, but you have just made a mistake from the beginning, observe that $$ \operatorname{arsinh} x =\ln \left ( x + \sqrt{x^2 \color{red}{+} 1} \right )\ne \ln(x+\sqrt{x^2-1}). $$