My textbook (independently written by a professor at my university) states the following definition:
Let $A \subset \mathbb{R}$. We define the opposite of $A$ as the set of all the opposite elements: $-A = \{x \in \mathbb{R} : -x \in A\}$
The book than gives an example, if $A = [-1, 3)$ then $-A = (-3, 1]$. However the bit I can't quite understand is this: take for example the points $x = \frac{1}{2}, y = 2$, both are real numbers but only one satisfies the condition since $-x \in A, -y \notin A$.
Shouldn't the definition be $-A = \{-x \in \mathbb{R} : x \in A\}$ or is it just saying the same thing?
I don't see what confusion your example results in. Perhaps you've done a mistake. You have $-x\in A$ and $x\in -A$ because $-3<x = 1/2 \le 1$, also you have $-y \notin A$ and $y\notin -A$ because $1 < y = 2$.
Your alternate definition may look fine on the surface and it suffices if you understand it correctly and it's equivalent.
However there's a problem/gotcha in that kind of construct in general. Let suppose we used another transform $\phi$ then your style of definition would be $\phi A = \{\phi x: x \in A\}$, but that raises the question of given a $\phi x$ candidate for membership, which $x$ do we test for membership in $A$ to decide if $\phi x\in \phi A$? If it's a bijective operation like $-$ this is not a real problem.
Actually your professors notation has the same weakness in that it is wrong if you just write $\phi A = \{x: \phi x \in A\}$, this is not what is meant, it just happens to work for negation.
The general definition of $\phi A$ is instead something like $\phi A = \{u: \exists x\in A(u=\phi (x))\}$ - somewhat similar to your, it's the same if you apply the understanding that $\{\phi x: x\in A\}$ means that given a $\phi x$ there exists a solution $x\in A$.