We are given two independent random variables $X_1$ and $X_2$. We need to check whether $X_1$ and $X_1 X_2$ are independent or not.
Probability functions are given as : $P(X_i = -1) = P(X_i = 1) = \frac{1}{2}$ for $i=1,2$
Simply by looking at the random variables $X_1$ and $X_1 X_2$ can't we just conclude both are dependent, since the value of $X_1 X_2$ clearly depends on $X_1$ ? Or this isn't the way to proceed ?
Functional dependence and stochastic dependence are two different things. Think about a random variable $X$ which takes the values $1$ and $-1$ with probability $1/2$. Then $X^2=1$ which is constant, so $X$ is stochastically independent on $X^2$, even though they are functionally dependent. So the only way to check for stochastic independence in your example is to verify whether $$P(X_1=i,X_1X_2=j)=P(X_1=i)P(X_1X_2=j)$$ for $i,j\in\{-1,1\}$.