I am given the subset $A=\{(x, \sin(1/x)) | x>0\} \bigcup \{(0,y) | y \in [-1,1] \}\subset \mathbb{R}^2$ equipped with the standard Euclidean metric
I came to the conclusion that it is not open because for $x>$[some finite value>0], we clearly just have a 1 dimensional line in $\mathbb{R}^2$, about which none of the points have an open ball of finite radius that is entirely contained within the subspace (line).
To determine if it is closed, I have to consider whether its complement is open. On the one hand it is true that any point I can state in $\mathbb{R}^2$ (i.e. write the numbers down for) that is not contained in $A$, I can find an open ball around that is not contained in $A$, even if it is very close to $x=0$. I also cannot think of how I would construct a sequence in$A$ whose limit point is not in $A$, and of course if $L(A)=A$, then $A$ is closed.
However I am having trouble reconciling this with the fact that the sinusoidal squiggles become infintitely close as $x\rightarrow 0$. It is easy to show that the distance between adjacent intersections of the $y=0$ axis $\rightarrow 0$ as $x\rightarrow 0$. It makes it feel like the complement shouldn't really be open...
Would I be correct in thinking that the fact that the definition hinges on stating a specific element in the set or complement is the significant point here?
Also, I wanted to verify that $A=\{(x,y)| x\in \mathbb{Q}, y^n = x $ such that $ n\in \mathbb{Z}^+\}$ is neither open nor closed.
You are correct that $A$ is not open.
The set $A$ is also closed. As far as I can tell, there is no straightforward argument which follows directly from the definitions. Here is a possible alternative:
Recall that if $f(x,y)$ is continuous, then the set $f(x,y)=0$ is closed. Now consider the function $f(x,y)=x\sin(1/x)-xy$. It's fairly straightforward to show that $x\sin(1/x)$ is continuous, despite the squiggle. Then to solve $f(x,y)=0$, note that $0=(\sin(1/x)-y)x$, so either $x$=0 or $\sin(1/x)-y=0$. Thus the zero set of $f(x)$ is $A\cup\{(x,0)|y\in\mathbb{R}\}$. Now $A$ is the intersection of this set with the closed set $\{(x,y)|x\in\mathbb{R},y\in[-1,1]\}$. Recall that the intersection of two closed sets is closed. Thus $A$ is closed.
Since your second question is unrelated to the first, I would recommend deleting it and reposting it as a second question.