I used the line point distance formula and tried to minimize that
$$\frac{Ax+By+C}{\sqrt {A^2 + B^2 }}$$ Putting $y=\cosh x$ $$\frac{Ax+B\cosh x+C}{\sqrt {A^2 + B^2 }} = G(x)$$ Using values of A and B from $y=x$
$$\frac{x-\cosh x}{\sqrt {2 }} = G(x)$$ and I minimized $G(x)$ using derivatives
$$\frac{1-\sinh x}{\sqrt {2 }} = G'(x)\implies \sinh x=1$$ but then the $x$ value for that doesn't seem to be the $x$ value which minimizes the distance.
You are correct, the shortest distance between the line $y=x$ and the curve $y=\cosh(x)$ is attained when $\sinh(x)=1$, that is at $$x_0=\text{arcsinh}(1)=\ln(1+\sqrt{2}).$$ which yields that the desired shortest distance is $$d=\frac{|x_0-\cosh(x_0)|}{\sqrt {2 }}=\frac{|\ln(1+\sqrt{2})-\sqrt{2}|}{\sqrt {2 }}=1-\frac{\ln(1+\sqrt2)}{\sqrt2}\approx 0.37677.$$