The number of eggs that a spider puts in a tree is distributed $Poisson(λ)$, however, this variable can only be observed if it is positive because if it is $0$ you can't know if the spider was in the tree or not. Let Y be the observed number of eggs, therefore: $P(Y=i)=P(X=i|X>0)$
Determine the E[Y].
My attempt:
I define a random variable $X$ that tells us the number of eggs that the spider puts into the tree.
So $Y=X$ iff $X>0$ and $Y=0$ in other case.
Therefore, $E(Y) = \sum_{y=1}^{\infty} (yλ^{y}e^{-λ})/y!= e^{-λ}(λ+(λ^2/2) + ...) = λe^{-λ}e^{λ} = λ$
Am I right?
You have already defined the correct $Y$ when you wrote $Y$ in terms of $X \sim Poisson(\lambda)$:
$$P(Y=i) = P(X=i \mid X > 0)$$
Perhaps you meant for this formula to be valid for any $i>0$, and that is certainly true. However, in fact this formula is also valid for $i=0$, because in that case $P(Y=0)= P(X = 0 \mid X > 0) = 0$.
Now expand for any $i>0$:
$$P(Y=i) = P(X = i \mid X > 0) = {P(X = i \cap X> 0) \over P(X>0)} = {P(X = i) \over P(X>0)} $$
Using the fact $X \sim Poisson(\lambda)$, you can calculate the numerator $P(X=i)$ and the denominator $P(X>0) = 1 - P(X=0)$, so that gives you $P(Y=i)$ for $i>0$.
Can you calculate $E[Y]$ from here? Further hint: $P(X>0)$ will turn out to be a common term you can "factor out" in the summation.
BTW, doing it the above way, i.e. finding each $P(Y=i)$ and then summing, is actually the hard way for this problem. I am going through all these details mainly as a way to help you "debug" your approach. For the much easier way, see the answer by @herbsteinberg